search

rumkin / pill

Add dynamic content loading to static sites with only 1 KiB of JS
https://rumkin.github.io/pill/
MIT License
383 stars 19 forks source link

Separate utils #30

Open tamb opened 4 years ago

tamb commented 4 years ago

I've moved the utility functions out and annotated them for sanity. They can now also be unit tested more easily.

tamb commented 3 years ago

@rumkin one 1.5, custom events, and lodash dependency are merged, should I resolve/refactor this one? I think it's a good idea to separate out as much of the library as we can so we can unit test, etc.

tamb commented 3 years ago

@rumkin Cool I should have time this weekend to work on it.

tamb commented 3 years ago

@rumkin Is it cool to continue with this PR or should we shelve it? I am totally game for fixing the conflicts.

rumkin commented 3 years ago

You can fix conflicts or just create new PR, if it would be too messy.