search

rumpkernel / drv-netif-dpdk

DPDK interface driver for userspace TCP/IP stack
Other
197 stars 54 forks source link

modified: examples/udp_echo_server/udp_echo_server.c #10

Closed ywahl closed 10 years ago

ywahl commented 10 years ago 
    Fixed bug, the buffer was not echo'ed as supposed too. An empty buffer was send, instead of the received message

modified: src/libdpdkif/dpdkif_user.c -Make it work on vmxnet3: vmxnet3 interfaces do not support multisegment transmit and require a least 512 buffer descriptors -dpdk complains if you assign all the buffers to the dev rxq/txq, since it cannot get any new free buffers to replish the queues.

anttikantee commented 10 years ago

Thanks for the contribution.

Can you do some minor adjustments: 1) explain why ETH_TXQ_FLAGS_NOOFFLOADS is set 2) replace "/ 4" with a more obvious mechanism, e.g. macro 3) submit separate issues as separate pull requests (udp_echo and vmxnet3) 4) make sure you follow the existing style of the files you are patching (indentation etc.) ?

thanks!

alexanderguy commented 10 years ago

Huh, I think we just found a github bug: I didn't merge this pull request. Maybe github got confused because the pull-request's branch got deleted, and another commit was made?

ywahl commented 10 years ago

Hi

I deleted the commit, because you asked me, to do 2 commits and some additional modifications. Which I haven't had the time to do yet.

Yaron

On Wednesday, October 29, 2014 8:29 AM, Alexander Guy notifications@github.com wrote:

Huh, I think we just found a github bug: I didn't merge this pull request. Maybe github got confused because the pull-request's branch got deleted, and another commit was made? — Reply to this email directly or view it on GitHub.

alexanderguy commented 10 years ago

Deleting the branch was fine. Thank you for taking the time to update your changes.