search

rumpkernel / rumprun-packages

Ready-made packages of software for running on the Rumprun unikernel
Other
202 stars 80 forks source link

zeromq with two tests and benchmark #128

Closed kvart2006 closed 7 years ago

anttikantee commented 7 years ago

Thanks, looks interesting, and I'm especially happy that you are publishing your benchmarks.

A few notes:

Also, there is no need to close and reopen pull requests. Just edit your own branch, squash the commits as necessary (with git rebase), and force push to your own branch. The result will be seen in the PR.

I'll send you a push access invitation once you address the above points.

anttikantee commented 7 years ago

Oh, and you should add this package to .travis.yml if possible.

kvart2006 commented 7 years ago

Hi,

You are right, I did not want to force push. I noted your remark for the future. Thanks

On Sat, Dec 31, 2016 at 11:11 AM, Antti Kantee notifications@github.com wrote:

Thanks, looks interesting, and I'm especially happy that you are publishing your benchmarks.

A few notes:

  • "compile by typing Makefile" is probably a typo.
  • what does "rumprun qemu is irrelevant in this context" mean? no overhead? too slow? what about kvm? (sorry I looked just at the text, as viewing the diff does not show images)

Also, there is no need to close and reopen pull requests. Just edit your own branch, squash the commits as necessary (with git rebase), and force push to your own branch. The result will be seen in the PR.

I'll send you a push access invitation once you address the above points.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/128#issuecomment-269858573, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi3Q3HrgNZk3XcmoA2bBoJ-6KOU8uks5rNiprgaJpZM4LYg60 .

anttikantee commented 7 years ago

You still need to squash your commits into one to clean up the public history before merge. Also, you need to resolve the conflict.

kvart2006 commented 7 years ago

Done; I cannot see the conflict. Sorry.

On Tue, Jan 3, 2017 at 3:00 PM, Antti Kantee notifications@github.com wrote:

You still need to squash your commits into one to clean up the public history before merge. Also, you need to resolve the conflict.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/128#issuecomment-270119780, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi6ARUs67N1MAAk_AlbB0FR08xqrWks5rOlRvgaJpZM4LYg60 .

kvart2006 commented 7 years ago

Antti, Please tell me if something is still missing for the zeromq package. Thanks, Bela

On Sat, Dec 31, 2016 at 11:17 AM, Bela Berde bela.berde@gmail.com wrote:

Hi,

  • Yes I wanted to say use Makefile.
  • qemu seems really slow. Irrelevant is too strong, I agree to, even thought, the comparison is, in general, made against docker. (At least this is the productivity goal in my company).

You are right, I did not want to force push. I noted your remark for the future. Thanks

On Sat, Dec 31, 2016 at 11:11 AM, Antti Kantee notifications@github.com wrote:

Thanks, looks interesting, and I'm especially happy that you are publishing your benchmarks.

A few notes:

  • "compile by typing Makefile" is probably a typo.
  • what does "rumprun qemu is irrelevant in this context" mean? no overhead? too slow? what about kvm? (sorry I looked just at the text, as viewing the diff does not show images)

Also, there is no need to close and reopen pull requests. Just edit your own branch, squash the commits as necessary (with git rebase), and force push to your own branch. The result will be seen in the PR.

I'll send you a push access invitation once you address the above points.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/128#issuecomment-269858573, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi3Q3HrgNZk3XcmoA2bBoJ-6KOU8uks5rNiprgaJpZM4LYg60 .

anttikantee commented 7 years ago

You have closed this pull request and the files are unavailable at least from the github interface. That's the most pressing issue.