Closed kvart2006 closed 7 years ago
Hi, Done. I hope, I corrected (in the right way) the NEW LINE issues. Bela
On Mon, Jan 9, 2017 at 4:22 PM, huikang notifications@github.com wrote:
@huikang requested changes on this pull request.
should zeromq/benchmark/benchmark.nb be removed from the PR? Thanks.
In zeromq/README.md https://github.com/rumpkernel/rumprun-packages/pull/129#pullrequestreview-15719917 :
@@ -0,0 +1,60 @@ +# Overview + +This is zeromq 4.2.2 for rumprun. The test platform is running Ubuntu 16.04 and the compilation options include
-std=c++17
. + +## Maintainer + + Bela Berde, bela.berde@gmail.com + Github: @kvart2006 + +## Instructions +Use the includedMakefile
by typingmake
. Note thatlibtool
is required to runautogen.sh
, andautomake
andautoconf
forconfigure
.what is the expected outcome of the make? For example, could you point out what are the executables or binaries out of the make command.
In zeromq/README.md https://github.com/rumpkernel/rumprun-packages/pull/129#pullrequestreview-15719917 :
+
+$ x86_64-rumprun-netbsd-gcc <filename> -I <path-to-zeromq-package>/include \ +-L <path-to-zeromq-package>/lib -lpthread -lzmq -o <filename-output> +
+Example (testing): ++<path-to-zeromq-package>/lib = /root/git/rumprun-packages/pkgs/lib +<path-to-zeromq-package>/include = /root/git/rumprun-packages/pkgs/include + +x86_64-rumprun-netbsd-g++ -std=c++17 example1.cpp -I/root/git/rumprun-packages/pkgs/include -L/root/git/rumprun-packages/pkgs/lib -lpthread -lzmq -o example1-rr + +rumprun-bake hw_generic example1-rr.bin example1-rr + +rumprun qemu -i example1-rr.bin +
+All other steps (baking, running) remain the same.What do you mean by "all other steps"? Does it refer to the other example?
In zeromq/README.md https://github.com/rumpkernel/rumprun-packages/pull/129#pullrequestreview-15719917 :
+ +rumprun-bake hw_generic example1-rr.bin example1-rr + +rumprun qemu -i example1-rr.bin +
+All other steps (baking, running) remain the same. + +### Example 1 +A simple one-way zeromq messaging using ZMQ_REQ and ZMQ_REP. + +### Example 2 +A simple one-way zeromq messaging using ZMQ_DEALER (asynchronos). + + +## Benchmark +The rumprun xen benchmark is against docker and rumprun qemu. All the tests are performed in Virtualbox by simply running the
exemple1``` 10 times. Note that the goal here is to have a first performance trend, and not to globally evaluate rumprun performance.it is not clear to me how others can reproduce the results with your examples. Could you provide some stey-by-stey command to run the test?
In zeromq/examples/example2/example2.cpp https://github.com/rumpkernel/rumprun-packages/pull/129#pullrequestreview-15719917 :
- assert (cont_rep != NULL);
- sin = rcv_string (cont_rep, ZMQ_DEALER, "tcp://*:5580");
- std::cout <<" Message rcv: " << sin << std::endl;
- std::cout << "=======================" << std::endl;
- ind = zmq_ctx_destroy (cont_rep);
- assert (ind == 0);
- end = std::chrono::system_clock::now();
- std::chrono::duration
elapsed_seconds = end-start; - std::time_t end_time = std::chrono::system_clock::to_time_t(end);
- std::cout << "Elapsed time = " << elapsed_seconds.count() << " sec\n";
- return 0; +}
newline
In zeromq/examples/example1/example1.cpp https://github.com/rumpkernel/rumprun-packages/pull/129#pullrequestreview-15719917 :
- ///=========================================================================
- void *cont_rep = zmq_ctx_new ();
- din = rcv_double (context, ZMQ_REP, "tcp://*:5580");
- std::cout <<" Message rcv: " << din << std::endl;
- std::cout << "=======================" << std::endl;
- ind = zmq_ctx_destroy (context);
- assert (ind == 0);
- end = std::chrono::system_clock::now();
- std::chrono::duration
elapsed_seconds = end-start; - std::time_t end_time = std::chrono::system_clock::to_time_t(end);
- std::cout << "Elapsed time = " << elapsed_seconds.count() << " sec\n";
- return 0; +}
newline
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/129#pullrequestreview-15719917, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi8x7C99NdvPSAnejcljsskSh-_Swks5rQlCcgaJpZM4LdAZV .
@kvart2006
Done. Thanks.
On Wed, Jan 11, 2017 at 3:28 AM, huikang notifications@github.com wrote:
@kvart2006 https://github.com/kvart2006
- There are still some newline missing the cpp files
- Please remove the binary file benchmark.nb
- Add other comments inline
- Squash the commits in the PR. Thanks.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/129#issuecomment-271760576, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMiy31nPDlqUxhD4Fl6RBwpmWxsGe4ks5rRD5QgaJpZM4LdAZV .
Like I told you at least once, do not close and open new pull requests! That makes tracking the discussion extremely difficult. I am closing #131. Update this pull request with your changes.
Really sorry! Each time I want to squash the commits, I crash my local git repo.
On Wed, Jan 11, 2017 at 11:09 PM, Antti Kantee notifications@github.com wrote:
Like I told you at least once, do not close and open new pull requests! That makes tracking the discussion extremely difficult. I am closing #131 https://github.com/rumpkernel/rumprun-packages/pull/131. Update this pull request with your changes.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/129#issuecomment-272011462, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi5_shpwncs6qHt_tvJ1jt61imWCvks5rRVMogaJpZM4LdAZV .
If you post details on what you're doing and what happens, somebody might be able to help.
But, you should generally contact the git communities if you have problems with git.
There are still two commits which should be squashed into one.
Also, the commit message could be a few words more verbose, e.g. simply "add zeromq package"
Oh, and please comment when you've fixed things. I'll then send you an invite to join the group and you can finally merge your contribution!
hopefully your git repo doesn't crash this time! ;-)
Thank you. What is the command to squash the two commits? I looked at on the web but I make still something wrong. (Next time I will not use forking. I feel really unproductive and I apologize for the inconvenience. )
On Fri, 13 Jan 2017 at 19:02, Antti Kantee notifications@github.com wrote:
Also, the commit message could be a few words more verbose, e.g. simply "add zeromq package"
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/129#issuecomment-272504614, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi2-fXQPFTDX8xAZ_JpzdTxDdpLL9ks5rR7wcgaJpZM4LdAZV .
-- Sent from iPad
I use git rebase -i
to squash commits.
You can edit the commit message of the latest commit with git commit --amend
(if it's not the latest commit, you'd have to use git rebase
first, and select the commit for editing).
Again, posting details on what went wrong might allow someone to help solve your problem.
Thanks again. I squashed using your commands. Sorry for being troublesome.
I still see 4 commits. Please check the "commits" tab above.
Looks good to me! I'll send you an invite. If you want to contribute more in the future, please remember to clean up the history and review the commits before you push (force push to rumpkernel/rumprun-packages is disabled).
Many mhanks.
On Sun, 22 Jan 2017 at 23:24, Antti Kantee notifications@github.com wrote:
Looks good to me! I'll send you an invite. If you want to contribute more in the future, please remember to clean up the history and review the commits before you push (force push to rumpkernel/rumprun-packages is disabled).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/129#issuecomment-274364873, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi_pCwcUWT1LakipSatQC6g3avSTNks5rU9cngaJpZM4LdAZV .
-- Sent from iPad
remember to click the "merge" button ;-)
Yes! Thank you.
On Mon, 23 Jan 2017 at 15:33, Antti Kantee notifications@github.com wrote:
remember to click the "merge" button ;-)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/129#issuecomment-274502868, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMi4r9lKhM98L_cRBmYDyls1zdpB63ks5rVLougaJpZM4LdAZV .
-- Sent from iPad
Done, many thanks!
On Sat, Jan 7, 2017 at 11:35 PM, huikang notifications@github.com wrote: