Closed thehajime closed 7 years ago
I sent you an invite so that you can merge your fixes.
If you're not sure how to deal with something, file an issue, assign it to the maintainer, an in case the maintainer is nowhere to be found in a few days, disable the package.
The compiler is too old on Travis. I will remove the two packages ( I will put back them later ). Thanks
On Wed, 22 Mar 2017 at 12:55, Antti Kantee notifications@github.com wrote:
I sent you an invite so that you can merge your fixes.
If you're not sure how to deal with something, file an issue, assign it to the maintainer, an in case the maintainer is nowhere to be found in a few days, disable the package.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/136#issuecomment-288376673, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMixbcKOApN2InLj1OoN3UuV1TpWf5ks5roQwygaJpZM4Mjz1n .
-- Sent from iPad
On 22/03/17 11:59, kvart2006 wrote:
The compiler is too old on Travis. I will remove the two packages ( I will put back them later ).
What is "too old"? Can you document the minimum required compiler in the README? If it's something that supports -std=c++17, it needs to explicitly stated as a requirement.
Also, please don't remove the packages, just disable them from the automated tests, pending fixes to the Travis env.
Ok, I will disable them. I am also thinking about a system that works like Travis but for Rumpkernel. Travis is using Docker containers and Ubuntu 12.04. A bit redondant in this context. That platform could be more Xen oriented etc.
On Wed, 22 Mar 2017 at 13:03, Antti Kantee notifications@github.com wrote:
On 22/03/17 11:59, kvart2006 wrote:
The compiler is too old on Travis. I will remove the two packages ( I will put back them later ).
What is "too old"? Can you document the minimum required compiler in the README? If it's something that supports -std=c++17, it needs to explicitly stated as a requirement.
Also, please don't remove the packages, just disable them from the automated tests, pending fixes to the Travis env.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/rumpkernel/rumprun-packages/pull/136#issuecomment-288378390, or mute the thread https://github.com/notifications/unsubscribe-auth/AFyMiznnskLLgPbvoGqQtKlfxTXtewifks5roQ4YgaJpZM4Mjz1n .
-- Sent from iPad
Ok, I will disable them.
@kvart2006 for your information, travis can ignore test errors by marking allow_failures:
in .travis.yml if the errors are intentional. The below is my trial to do this: hope it helps a bit.
I sent you an invite so that you can merge your fixes.
@anttikantee thanks. I will merge this PR soon.
Two fixes for rumprun-package test on travis-ci.
The test still fails with packages (servus and zerobuf), which I'm not sure how to fix it.