search

rumpkernel / rumprun-packages

Ready-made packages of software for running on the Rumprun unikernel
Other
202 stars 79 forks source link

Initial packaging of libcurl #63

Closed smalldave closed 8 years ago

anttikantee commented 8 years ago

Thanks, looks good.

Did you test that it works?

Can you improve the description to include a few words on what libcurl is, for the benefit of those who might not know. "packaging of x for rumprun" is redundant, it's implied by the repository ;-)

I'll invite you to the rumprun-packages team in a few moments, and after accepting you can merge this PR.

anttikantee commented 8 years ago

Oh, does the email address you listed for maintainer work now?

smalldave commented 8 years ago

I've tested it works. Run it from a completely clean Docker container and builds fine.

I'll add some blurb.

I've tried that email from a couple of my other email addresses. Seems to work fine for me. Feel free to send me an email.

anttikantee commented 8 years ago

I meant if you checked that the built library works, not only if it can be built. Unsure which your answer means.

btw, add the email address you're committing with to your github account.

smalldave commented 8 years ago

oh you mean actually works. looking at that now. will let you know.

anttikantee commented 8 years ago

Ok, thanks. Merge after it works, as in at least one program runs against libcurl. Based on prior experience, I don't expect trouble, but you never know ...

smalldave commented 8 years ago

on an ec2 instance gets as far as "can't resolve host". Not sure if that counts as working but it is definitely doing something. i'm done for the day so can get back to this tomorrow

smalldave commented 8 years ago

that is returned from libcurl BTW

anttikantee commented 8 years ago

DNS is not configured unless you know where to hack it in, so that would be one reason you get that error ;-)

Testing on EC2 is quite painful, I'd recommend using something like qemu locally and only when you get things fully working, test on EC2.

anttikantee commented 8 years ago

I added an empty resolv.conf to rumprun-packages/stubetc/etc. That's what you need to edit. One well-known public DNS server is at 8.8.8.8 (which you should use only if you trust Google).

smalldave commented 8 years ago

Ok. I quite like the idea of not having any file system drivers. If I care enough it's not too difficult to roll your own dns client. Think I can live without DNS for a bit anyway.

smalldave commented 8 years ago

Switched to IP addresses and it all worked fine.

anttikantee commented 8 years ago

Great, then please merge your pull request!

Thanks!

smalldave commented 8 years ago

Do I have the right to push?

anttikantee commented 8 years ago

On 13/01/16 12:06, David Smith wrote:

Do I have the write to push?

Yes, after you accept the invitation the rumprun-packages team.

smalldave commented 8 years ago

I've not received that. Email problems again?

anttikantee commented 8 years ago

On 13/01/16 12:15, David Smith wrote:

I've not received that. Email problems again?

I don't know what precisely went wrong, as I don't have access to github's logs. In any case, the email is not critical, since you accept the invitation from the github web ui.

smalldave commented 8 years ago

As far as I know I haven't received any notification via the ui or through email that I was invited to join the packages team.

anttikantee commented 8 years ago

On 13/01/16 13:37, David Smith wrote:

As far as I know I haven't received any notification via the ui or through email that I was invited to join the packages team.

I tried clicking "update invitation" for you. No idea if that sends another email.

Also, the box says: "Invitations are sent via email and can be accepted at https://github.com/rumpkernel"

If you still don't get emails or can't accept, I can't do anything else, since I don't see into github's internals.

smalldave commented 8 years ago

I hadn't gone to the org home page. I've accepted now. Ta. Not sure what is happening to the email