search

rumpkernel / rumprun-packages

Ready-made packages of software for running on the Rumprun unikernel
Other
202 stars 79 forks source link

PHP: Add running make to nginx+php demo README #83

Closed JelteF closed 8 years ago

JelteF commented 8 years ago

This seems like quite an important step.

anttikantee commented 8 years ago

[php package maintainer is on vacation this week, so I'm handling this]

I guess the "examples" section assumes that "instructions" have already been followed. The various package READMEs are in disarray because we haven't figured out good templates that each readme should follow...

Do things work with the suggested patch? It omits the baking step from "instructions". Also, not entirely related, but looking at the steps, shouldn't step 3 be done before step 1?

JelteF commented 8 years ago

It is indeed not enough to get it running all by itself. You also need to do steps at the top of the page. However, after changing the content of images/data the image needs to be created again, otherwise the nginx IP remains unchanged.

anttikantee commented 8 years ago

Can you update your branch to reflect the above? Also, please test that following the steps from scratch works. After that, I can merge your contribution. Thanks.

JelteF commented 8 years ago

I changed it a bit to mention it just rebuilds the image. It seems quite fair to assume that people did the top part of the README.

anttikantee commented 8 years ago

Thanks!