rumpkernel / rumprun-packages

Ready-made packages of software for running on the Rumprun unikernel
Other
203 stars 79 forks source link

localhost might not be default available in the env, explicitly set ip #95

Closed maniankara closed 8 years ago

maniankara commented 8 years ago

fix for: https://github.com/rumpkernel/rumprun-packages/issues/94

reuben-sutton commented 8 years ago

This is great. Thank you!

anttikantee commented 8 years ago

I added /etc/hosts to Rumprun to make sure "localhost" is always resolvable (which was a good thing to add in any case). Does that fix the issue?

maniankara commented 8 years ago

Fixed atleast for me.

anttikantee commented 8 years ago

Does it make sense to revert the doc change?

maniankara commented 8 years ago

Thats fine to revert it, as it works now without the -o param. However, I think, there should be more options than just defaults. @reuben-sutton what do you say?

One more question, not related to this patch itself: Is it worth to try to get a working rails out of this? I spend some time last weekend trying to sort this out and reached a point when "nokogiri.so" which is shipped as nokogiri gem needs re-compiling with rumpkernel. Please suggest, I can spend some more time on this if its worth. Thoughts?

anttikantee commented 8 years ago

I can't say if it's desirable to get rails working, but if you think it is, I will do my all to support that goal.