run-ai / genv

GPU environment and cluster management with LLM support
https://www.genv.dev
GNU Affero General Public License v3.0
447 stars 20 forks source link

zsh error #12

Open dvolgyes opened 1 year ago

dvolgyes commented 1 year ago

Hi,

Great project. I started to play with it, and seems to work well in bash, but it fails immediately in Zsh.

> genv activate                     
_genv_backup_env:2: bad substitution

Probably you used a bash-specific idiom which doesn't work in Zsh.

As a generic advice, maybe running shellcheck could give you improvement ideas: https://github.com/koalaman/shellcheck

razrotenberg commented 1 year ago

Hi @dvolgyes and thanks for pointing it out!

We are aware of this issue. This is because of the way we create some of the environment variables and especially because we use ! in parameter substitution here which is supported in bash but not in zsh where it's (P) instead.

For now, Genv officially supports only bash, and supporting more shells is for sure a task that needs to be done. Also, zsh is probably the first one to add support to.

I have some poc of zsh support. I will see if I can make it work, I will create a branch and update you so that you could git checkout this branch and try it yourself.

What I recommend you is to use bash in the meantime and you can do it by running exec bash for example.

razrotenberg commented 1 year ago

Hi again @dvolgyes !

I published the branch with zsh support (feature/zsh). I want to test it better before merging it to master.

Until then, you should checkout this branch in order to work with your zsh setup. To do this, open your terminal and run the following:

cd ~/genv
git pull
git checkout feature/zsh

You should probably restart your shell for it to take effect.

It'd be great if you could use it in your zsh setup and provide feedback if it works properly or if something is not working right 🙃

dvolgyes commented 1 year ago

Hi @razrotenberg ,

Thanks. I will try, but I am a bit busy with end of year deadlines, so I don't promise regular updates. But I will try my best.

razrotenberg commented 1 year ago

Hi @dvolgyes ,

Have you had some time to try the zsh support?