run-house / runhouse

Dispatch and distribute your ML training to "serverless" clusters in Python, like PyTorch for ML infra. Iterable, debuggable, multi-cloud/on-prem, identical across research and production.
https://run.house
Apache License 2.0
980 stars 37 forks source link

Keep secrets in user namespace, fix creds on den teardown #1452

Closed mkandler closed 1 week ago

mkandler commented 1 week ago
sentry-io[bot] commented 1 week ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/launcher_utils.py

Function Unhandled Issue
up Exception: Received [403] from Den POST 'https://api.run.house/cluster/up': {'detail': 'Not authenticated'} ...
Event Count: 3
up Exception: Received [500] from Den POST 'https://api.run.house/cluster/up': {'code': 404, 'detail': 'No clus... ...
Event Count: 2
up AttributeError: module 'runhouse.rns.rns_client' has no attribute 'username' runhouse.resources.secr...
Event Count: 2
📄 File: runhouse/resources/secrets/secret_factory.py (Click to Expand) | Function | Unhandled Issue | | :------- | :----- | | **`secret`** | [**AttributeError: module 'runhouse.rns.rns_client' has no attribute 'username'**](https://runhouse.sentry.io/issues/6076216709/?referrer=github-open-pr-bot) runhouse.resources.secr...
`Event Count:` **2** |

Did you find this useful? React with a 👍 or 👎

mkandler commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.