run-house / runhouse

Like PyTorch for building ML systems. Iterable, debuggable, multi-cloud, 100% reproducible across research and production.
https://run.house
Apache License 2.0
942 stars 37 forks source link

Use default env vars in sky launch #926

Closed carolineechen closed 1 week ago

sentry-io[bot] commented 2 weeks ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/on_demand_cluster.py

Function Unhandled Issue
up TypeError: argument of type 'NoneType' is not iterable app in li...
Event Count: 1
up ValueError: Invalid instance type 'L4' for cloud GCP. main in...
Event Count: 1
up TypeError: argument of type 'NoneType' is not iterable generic ASGI r...
Event Count: 1
up ValueError: Failed to restart server recsys-cluster main in <modu...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

carolineechen commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on Graphite Graphite

carolineechen commented 1 week ago

setting env in sky task doesn't actually set the env vars for the cluster, just for running the sky task