search

run-llama / LlamaIndexTS

LlamaIndex in TypeScript
https://ts.llamaindex.ai
MIT License
1.78k stars 339 forks source link

Python compatibility with PineconeVectorStore #873

Open kilimchoi opened 4 months ago

kilimchoi commented 4 months ago

Hi, I noticed that in https://github.com/run-llama/LlamaIndexTS/blob/b963782137c7e8e1142701f3dddade3c9d8db6f4/packages/core/src/Node.ts#L4, all the enum values are in string. But if I use the python llamaindex to do queries after embedding documents with llamaindex.ts, I get an error message value is not a valid enumeration member; permitted: '1', '2', '3', '4', '5'. This seems to be happening because python's NodeRelationship is using an integer value for SOURCE, PREVIOUS, NEXT, PARENT, and etc. Is there a reason why the typescript package is using the string instead?

marcusschiesser commented 3 months ago

@kilimchoi which vector store did you use? we have a ticket for SimpleVectorStore, see https://github.com/run-llama/LlamaIndexTS/issues/862

kilimchoi commented 3 months ago

@marcusschiesser PineconeVectorStore