search

run-llama / chat-llamaindex

https://chat.llamaindex.ai
MIT License
849 stars 261 forks source link

Dockerfile & docker-compose.yml #13

Closed joshuasundance-swca closed 5 months ago

joshuasundance-swca commented 11 months ago

This PR introduces simple Docker support for the chat-llamaindex project. Here are the main highlights:

  1. Dockerfile: A multi-stage Dockerfile has been created. The build stage uses node:18-bookworm-slim to set up the application, and the production stage copies over the necessary build artifacts. I'm not sure this multi-stage process is entirely necessary here, but it seems like best practice.

  2. Docker-Compose: Added a docker-compose.yml file. This file defines a single service for the web app, ensures proper mapping for ports and volumes, and checks to be sure that OPENAI_API_KEY is defined.

  3. README Updates: Added a dedicated Docker section to guide developers on how to build and run the application using Docker and Docker Compose.

  4. .dockerignore: Added to ensure that certain files/folders, like .env.template and .github, are not included in the Docker build context. This may help in speeding up the build process and keep the Docker image clean.

Please review the changes and let me know if you have any questions or suggestions.

P.S. Thank you for all of your hard work. :)

vercel[bot] commented 11 months ago

@joshuasundance-swca is attempting to deploy a commit to the LlamaIndex Team on Vercel.

A member of the Team first needs to authorize it.

joshuasundance-swca commented 10 months ago

Anything I can do on this PR, or should it be closed? Thanks.

benlangfeld commented 5 months ago

@marcusschiesser is it possible to get some feedback here? Official Docker images would make this app easier to deploy to Kubernetes, for example.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chat-llama ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 5:29am
marcusschiesser commented 5 months ago

Sorry, @joshuasundance-swca and @benlangfeld - that must have slipped through. Merged it.

joshuasundance-swca commented 5 months ago

Awesome, thanks! Let me know if there are further contributions you'd like to see, particularly related to Docker and/or Kubernetes. :)