run-llama / create-llama

The easiest way to get started with LlamaIndex
MIT License
799 stars 96 forks source link

Incorrect References in settings.ts not caught by e2e #212

Closed balasubramaniam-ramasamy closed 2 weeks ago

balasubramaniam-ramasamy commented 1 month ago

I generated the app with the combinations of NextJs + Express + MongoDB.

The below code is found in ".\backend\src\controllers\engine\generate.ts" and ".\backend\src\controllers\engine\index.ts":-

import { MongoDBAtlasVectorSearch } from "llamaindex/storage/vectorStore/MongoDBAtlasVectorSearch";

However, I had to resolve the reference error with below code:

import { MongoDBAtlasVectorSearch } from "llamaindex";

Please, check if this update is needed.

balasubramaniam-ramasamy commented 1 month ago

Also in settings.ts

import { HuggingFaceEmbedding } from "llamaindex/embeddings/HuggingFaceEmbedding";
import { OllamaEmbedding } from "llamaindex/embeddings/OllamaEmbedding";
import { ALL_AVAILABLE_ANTHROPIC_MODELS } from "llamaindex/llm/anthropic";
import { Ollama } from "llamaindex/llm/ollama";
marcusschiesser commented 1 month ago

Thanks @balasubramaniam-ramasamy we'll update the references

marcusschiesser commented 1 month ago

@thucpn i updated the MongoDB references. Please have a look why the settings.ts are not caught by our e2e