Closed marcusschiesser closed 1 month ago
Latest commit: 1a818ef8bcd21de9f485d032855231846effd52a
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The recent changes streamline the checkAppHasStarted
and runCreateLlama
functions by simplifying their structure and reducing redundancy. The introduction of the waitPorts
and waitForProcess
helper functions enhances code modularity and readability. This refactoring consolidates port-waiting logic and clarifies timeout handling, ultimately making the codebase more maintainable and easier to understand.
Files | Change Summary |
---|---|
e2e/utils.ts |
Revised checkAppHasStarted to simplify port waiting logic; added waitPorts for concurrent port checks. Updated runCreateLlama to remove timeout handling; added waitForProcess for clearer process wait logic. |
In the code where rabbits hop,
We’ve tidied up, no need to stop.
With ports that wait and processes clear,
Our functions dance, no bugs to fear!
Hooray for changes, oh what a sight,
A bouncy code, all feels just right! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Bug Fixes
Refactor