fix: files in sub folders of 'data' are not displayed

marcusschiesser commented 4 weeks ago

Summary by CodeRabbit

New Features
- Improved file visibility within subfolders of the data directory, enhancing data access and management.
- Introduced a centralized DATA_DIR constant for easier configuration of data-related operations.
Bug Fixes
- Enhanced URL generation for files, particularly for private uploads, ensuring robust handling of file paths.
Improvements
- Modified API logic to improve folder path resolution based on the folder type, enhancing security and data management.
- Adjusted file mounting process to be more configurable by utilizing the DATA_DIR constant.

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: 6a47c9bee597feb7b6b4f67248ce2694d10035dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------ | ----- | | create-llama | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai[bot] commented 4 weeks ago

Walkthrough

This update enhances the application's file management by resolving visibility issues for files in subfolders, improving user access to data. It simplifies configuration through a centralized data directory definition and refines URL generation for file access. These changes collectively promote maintainability and flexibility in handling file paths, ensuring robust data management across the application.

Changes

Files	Change Summary
`.changeset/good-oranges-cover.md`	Introduced patch "create-llama" to display files in 'data' subfolders, enhancing file management.
`templates/components/loaders/python/file.py`	Removed `data_dir` from `FileLoaderConfig` for simpler initialization; updated `get_file_documents` to use `DATA_DIR`.
`templates/types/streaming/fastapi/app/config.py`	Added `DATA_DIR` constant for centralized data directory management.
`templates/types/streaming/fastapi/app/api/routers/models.py`	Enhanced `get_url_from_metadata` to handle file paths robustly using `DATA_DIR`.
`templates/types/streaming/fastapi/main.py`	Modified `mount_static_files` to use `DATA_DIR` for improved configurability.
`templates/components/llamaindex/typescript/streaming/events.ts`	Updated `getNodeUrl` to generate URLs using `DATA_DIR`, improving flexibility for file scenarios.
`templates/types/streaming/nextjs/app/api/files/[...slug]/route.ts`	Adjusted file path logic in the `GET` function to utilize `DATA_DIR`, enhancing path resolution.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant FileLoader

    User->>App: Request file access
    App->>FileLoader: Retrieve files from DATA_DIR
    FileLoader->>App: Return files
    App->>User: Display files

🐇 "In the world of code, where files do roam,
A patch was made to bring them home.
With paths now clear and access bright,
We're hopping along in pure delight!
Data flows freely, like carrots in spring,
A joyful change, let the rabbit sing!" 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

run-llama / create-llama