fix: dont include new message in chat history

thucpn commented 4 days ago

Summary by CodeRabbit

New Features
- Enhanced chat functionality by refining the context of chat history, now excluding the last user message for improved processing.
Bug Fixes
- Adjusted how chat history is populated to ensure more relevant context is passed to the chat engine.
- Implemented a fix to prevent the inclusion of user messages in the chat history, enhancing privacy.

changeset-bot[bot] commented 4 days ago

🦋 Changeset detected

Latest commit: c9c9f18620f13d44625fd573899834277500174b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------ | ----- | | create-llama | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai[bot] commented 4 days ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the chat function in two files: chat.controller.ts and route.ts. The primary alteration is in how the chatHistory variable is assigned; it now slices the messages array to exclude the last message, rather than including the entire array. This change affects the context of the chat history used in the chat engine's processing, while other aspects of the functions, such as error handling and response streaming, remain unchanged.

Changes

File Path	Change Summary
templates/types/streaming/express/src/controllers/chat.controller.ts	Modified `chatHistory` to exclude the last message from the `messages` array.
templates/types/streaming/nextjs/app/api/chat/route.ts	Modified `chatHistory` to exclude the last message from the `messages` array.
.changeset/brave-pears-reflect.md	Introduced a patch to prevent user messages from being included in chat history.

Possibly related PRs

#149: The changes in this PR also modify the chatHistory variable in a similar manner, slicing the messages array to exclude the last message, which directly relates to the handling of chat history in the main PR.
#202: This PR focuses on enhancing the reusability of components for chat LLMs, which may relate to the overall chat functionality being modified in the main PR, particularly in how chat history is managed.
#213: This PR addresses sending chat data when submitting messages, which could be relevant to the context of managing chat history and user messages in the main PR.
#267: This PR fixes the handling of props in the chat suggestion component, which may relate to the overall chat message handling and context management discussed in the main PR.
#302: The integration of LlamaIndexAdapter in this PR modifies how chat responses are handled, which could be relevant to the changes in the chat history management in the main PR.
#418: This PR updates the chat UI, which may involve changes in how chat messages and history are displayed, potentially connecting to the changes made in the main PR regarding chat history management.

Poem

In the chat where messages flow,
A slice of history, now we know.
The last one's gone, a fresh new start,
For clearer context, it plays its part.
With every chat, we hop and cheer,
For changes made, let’s spread the cheer! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

run-llama / create-llama