Closed leehuwuj closed 3 months ago
Latest commit: c3215ccc7bd1362f25e351e9d40afa58179f3064
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The recent updates aim to refine vector and index management in Python components and adjust FastAPI settings. Changes involve adding default namespaces, enhancing storage interactions, and improving data persistence mechanisms. Additionally, there are updates in parameter naming for OpenAI configuration initialization to ensure clarity and consistency.
File Path | Change Summary |
---|---|
.../vectordb.py |
Updated get_vector_store to include a default namespace in SimpleVectorStore . |
.../fastapi/app/engine/generate.py , .../fastapi/app/engine/index.py |
Enhanced data persistence logic, added necessary imports, and enabled conditional index loading from storage. |
.../fastapi/app/settings.py |
Updated parameter naming from dimension to dimensions in OpenAI initialization configurations. |
🐇✨ In the code garden, changes bloom, With namespaces and dimensions, no gloom. Persistence refined, paths now align, A rabbit hops through, leaving tweaks in design. Celebrate the craft, with every line's draft! 🌟 🐇✨
templates/types/streaming/fastapi/app/engine/generate.py (13)
5-5: Module level import not at top of file --- 6-6: Module level import not at top of file --- 7-7: Module level import not at top of file --- 8-8: Module level import not at top of file --- 9-9: Module level import not at top of file --- 10-10: Module level import not at top of file --- 11-11: Module level import not at top of file --- 12-12: Module level import not at top of file --- 13-13: Module level import not at top of file --- 14-14: Module level import not at top of file --- 15-15: Module level import not at top of file --- 16-16: Module level import not at top of file --- 17-17: Module level import not at top of file
templates/types/streaming/fastapi/app/engine/generate.py (1)
Line range hint `18-31`: The implementation of `get_doc_store` looks good.
Closed due to the ingestion pipeline issue. Move embedding dimension fixing into other PR.
To fix the issue of not retrieving any nodes.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
dimension
todimensions
in OpenAI initialization settings for clarity.