search

run-llama / create-llama

The easiest way to get started with LlamaIndex
MIT License
718 stars 86 forks source link

Add persist index store for Simple Vector Store #71

Closed leehuwuj closed 3 months ago

leehuwuj commented 3 months ago

To fix the issue of not retrieving any nodes.

Summary by CodeRabbit

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: c3215ccc7bd1362f25e351e9d40afa58179f3064

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates aim to refine vector and index management in Python components and adjust FastAPI settings. Changes involve adding default namespaces, enhancing storage interactions, and improving data persistence mechanisms. Additionally, there are updates in parameter naming for OpenAI configuration initialization to ensure clarity and consistency.

Changes

File Path Change Summary
.../vectordb.py Updated get_vector_store to include a default namespace in SimpleVectorStore.
.../fastapi/app/engine/generate.py, .../fastapi/app/engine/index.py Enhanced data persistence logic, added necessary imports, and enabled conditional index loading from storage.
.../fastapi/app/settings.py Updated parameter naming from dimension to dimensions in OpenAI initialization configurations.

🐇✨ In the code garden, changes bloom, With namespaces and dimensions, no gloom. Persistence refined, paths now align, A rabbit hops through, leaving tweaks in design. Celebrate the craft, with every line's draft! 🌟 🐇✨

Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 18ca18123f4314bd9e7cc59d675e9f2ddf3242d1 and c3215ccc7bd1362f25e351e9d40afa58179f3064.
Files selected for processing (1) * templates/types/streaming/fastapi/app/engine/generate.py (3 hunks)
Additional Context Used
Ruff (13)
templates/types/streaming/fastapi/app/engine/generate.py (13)
5-5: Module level import not at top of file --- 6-6: Module level import not at top of file --- 7-7: Module level import not at top of file --- 8-8: Module level import not at top of file --- 9-9: Module level import not at top of file --- 10-10: Module level import not at top of file --- 11-11: Module level import not at top of file --- 12-12: Module level import not at top of file --- 13-13: Module level import not at top of file --- 14-14: Module level import not at top of file --- 15-15: Module level import not at top of file --- 16-16: Module level import not at top of file --- 17-17: Module level import not at top of file
Additional comments not posted (1)
templates/types/streaming/fastapi/app/engine/generate.py (1)
Line range hint `18-31`: The implementation of `get_doc_store` looks good.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
leehuwuj commented 3 months ago

Closed due to the ingestion pipeline issue. Move embedding dimension fixing into other PR.