Closed sagech closed 3 months ago
Latest commit: 8bb1024d0f58ecc52c9acc327978eac7cf751b00
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The recent updates involve modifying the instantiation method of QdrantVectorStore
across two TypeScript files. The change transitions from using separate arguments for collectionName
and client
to a single object parameter that includes both properties. This adjustment aims to streamline the function calls and enhance code readability.
Files | Change Summary |
---|---|
.../vectordbs/typescript/qdrant/generate.ts |
Modified QdrantVectorStore instantiation to use an object parameter. |
.../vectordbs/typescript/qdrant/index.ts |
Similar modification as in generate.ts for QdrantVectorStore instantiation. |
🐰✨ In the land of code, where the bits align, A rabbit hopped through the script's spine. "Change is here!" it squeaked with glee, As it tweaked the code, for all to see. Now,
QdrantVectorStore
shines anew, With cleaner calls, our bugs we'll subdue! 🌟📜
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Bug Fixes
QdrantVectorStore
initialisation, where the constructor parameters are incorrectly provided. For reference, here's the constructor as defined inllamaindex
:https://github.com/run-llama/LlamaIndexTS/blob/75736ad01baf776f54e1d26f73e25d6faa9667a0/packages/core/src/storage/vectorStore/QdrantVectorStore.ts#L53-L59
Summary by CodeRabbit
QdrantVectorStore
by using an object parameter for better clarity and maintainability.