The JsonReader is currently not working. It only considers the Keys and ignores the content in Value. This is fixed in the PR, and also Unit tests are introduced to validate any further changes.
This is a PR to fix this, with syntactically accurate JSON retaining its original behavior of being passed entirely as single document. If multiple documents are required then a list of JSONobjects or JSONL needs to be passed.
Type of Change
Please delete options that are not relevant.
[ ] New Loader/Tool
[x] Bug fix / Smaller change
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense
Suggested Checklist:
[ ] I have added a library.json file if a new loader/tool was added
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x ] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods
nerdai
commented
8 months ago
Description
The JsonReader is currently not working. It only considers the Keys and ignores the content in Value. This is fixed in the PR, and also Unit tests are introduced to validate any further changes.
Fixes # (issue) Related to: https://github.com/run-llama/llama-hub/pull/485
Issue:
For syntactically accurate Json the actual value is missing and instead only the keys are present in the document Refer https://github.com/run-llama/llama-hub/issues/606 .
The line causing the issue (only dictionary keys are returned): https://github.com/run-llama/llama-hub/blob/c36cdc54b82ced1bffe792293d896ca5681a2e61/llama_hub/file/json/base.py#L79
Solution
This is a PR to fix this, with syntactically accurate JSON retaining its original behavior of being passed entirely as single document. If multiple documents are required then a list of JSONobjects or JSONL needs to be passed.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods