Closed tslmy closed 8 months ago
Fair arguments @tslmy. I can get behind this.
Can you fix so that it passes lint checks?
Done. Thanks for the review, @nerdai :D
looks like format
check not passing still. Did you run make format
and make lint
?
@nerdai , not yet, sorry. I was at work and no access to my personal dev machine. Doing it now.
Description
IMO, a tool should work differently from a Data Loader. A tool should return the content, and just the content, if possible. It should not expose to the LLM the fact that it is a Python program. The original implementation gives off the lower-level details to the LLM by emitting characters like these in the Observation:
This PR thrives to fix that. Here's a demo:
Before:
After:
I also don't think it's wise to load multiple pages with this tool, because each Wikipedia page alone is prone to exceed the context window of the LLM. Plus, the document separators would be too tiny for the LLM to notice. Most importantly, the multi-page support just doesn't match the README!
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods