run-llama / llama-hub

A library of data loaders for LLMs made by the community -- to be used with LlamaIndex and/or LangChain
https://llamahub.ai/
MIT License
3.44k stars 731 forks source link

Update base.py #839

Closed miezzi closed 7 months ago

miezzi commented 8 months ago

Description

support for configure delimiter and quotechar in paged_csv

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Suggested Checklist:

anoopshrma commented 8 months ago

Hi, thank you for the contribution!

All looks good except the linting. Could you take a look at that.

anoopshrma commented 7 months ago

@miezzi quick bump on this!

anoopshrma commented 7 months ago

seems like there's some minor linting errors you can fix with make lint; make format!

anoopshrma commented 7 months ago

Everything looks good now @miezzi . Merging it!!