Closed stewartjarod closed 5 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
out of curiosity @stewartjarod what were the issues you ran into in running tests?
I wasn't able to get the async tests to pass.
Right, at this time we provide a query for products and recommendations. Looking to expand from there. π
Ah, that's a weird failure. While I'm figuring this out, @jerryjliu do you want me to revert the package update for typings?
Tests should pass now π
Ah, that's a new one. Type responses like that must not be supported in 3.8. Sorry for the issues here with tests. Adding future annotations seemed to do the trick here.
Let me know if there is anything else I can do here! Thank you for your support.
Description
Ionic is a shopping assistant tool for llms. I've added the tool, which depends on our Ionic API SDK library.
While there, I updated the typing packages.
Note: I had issues with running tests locally, even on main, so I'm not entirely sure if this is good to merge without a CI/CD step for tests.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods