run-llama / llama-hub

A library of data loaders for LLMs made by the community -- to be used with LlamaIndex and/or LangChain
https://llamahub.ai/
MIT License
3.42k stars 727 forks source link

Ionic shopping tool #915

Closed stewartjarod closed 5 months ago

stewartjarod commented 5 months ago

Description

Ionic is a shopping assistant tool for llms. I've added the tool, which depends on our Ionic API SDK library.

While there, I updated the typing packages.

Note: I had issues with running tests locally, even on main, so I'm not entirely sure if this is good to merge without a CI/CD step for tests.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Suggested Checklist:

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jerryjliu commented 5 months ago

out of curiosity @stewartjarod what were the issues you ran into in running tests?

stewartjarod commented 5 months ago

I wasn't able to get the async tests to pass.

Right, at this time we provide a query for products and recommendations. Looking to expand from there. πŸ˜€

stewartjarod commented 5 months ago

Ah, that's a weird failure. While I'm figuring this out, @jerryjliu do you want me to revert the package update for typings?

stewartjarod commented 5 months ago

Tests should pass now πŸ‘

stewartjarod commented 5 months ago

Ah, that's a new one. Type responses like that must not be supported in 3.8. Sorry for the issues here with tests. Adding future annotations seemed to do the trick here.

stewartjarod commented 5 months ago

Let me know if there is anything else I can do here! Thank you for your support.