run-llama / llama-hub

A library of data loaders for LLMs made by the community -- to be used with LlamaIndex and/or LangChain
https://llamahub.ai/
MIT License
3.44k stars 732 forks source link

feat: allow use of self-signed cert for MinIO server with MinioReader #935

Closed ferdinandosimonetti closed 7 months ago

ferdinandosimonetti commented 7 months ago

Description

I've added cert_check as an option for MinioReader to avoid problems when the remote MinIO server has TLS enabled, but with a self-signed or untrusted certificate. How can I run my modified version of MinioReader locally, to perform some test?

Type of Change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Suggested Checklist:

anoopshrma commented 7 months ago

Try running make format; make lint to remove any linting issue

ferdinandosimonetti commented 7 months ago

Here we are...

ferdi@u820:~/llama-hub$ python -m venv ~/testing-llamahub
ferdi@u820:~/llama-hub$ . ~/testing-llamahub/bin/activate
(testing-llamahub) ferdi@u820:~/llama-hub$ pip install -r test_requirements.txt
(testing-llamahub) ferdi@u820:~/llama-hub$ pip install black[jupyter]
(testing-llamahub) ferdi@u820:~/llama-hub$ make format
black .
All done! ✨ 🍰 ✨
694 files left unchanged.
(testing-llamahub) ferdi@u820:~/llama-hub$ make lint
ruff check .
black --check .
All done! ✨ 🍰 ✨
694 files would be left unchanged.
review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

anoopshrma commented 7 months ago

Finally you conquered the linting god @ferdinandosimonetti 😆

Thank you for the quick response on the PR