[Feature Request]: Revisit `StopEvent` emission to terminate workflows

masci commented 3 months ago

Feature Description

Find a better way to terminate a normal workflow execution.

Reason

Individual steps should remain mostly unaware of the wider workflow, while at the moment they can halt a run by emitting the special StopEvent. A higher-level function should determine the “done” condition, while steps can emit errors/abort signals for exceptional circumstances.

Value of Feature

A more robust event-driven architecture for workflows.

logan-markewich commented 3 months ago

I guess I'd also be wary of the complexity needed to implement a stop function.

What does it need access to? Context? List of events already emitted? List of steps already run? Not sure actually 🤔

dosubot[bot] commented 2 weeks ago

Hi, @masci. I'm Dosu, and I'm helping the LlamaIndex team manage their backlog. I'm marking this issue as stale.

Issue Summary:

You proposed a feature to improve workflow termination by revising the use of StopEvent.
The current method allows individual steps to stop a workflow, which conflicts with the design principle of step isolation.
@logan-markewich raised concerns about the complexity and requirements of implementing a stop function.
The goal is to enhance the event-driven architecture by centralizing workflow completion management.

Next Steps:

Please let me know if this issue is still relevant to the latest version of the LlamaIndex repository by commenting here.
If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

masci commented 1 week ago

@dosubot keep it open

run-llama / llama_index