run-llama / llama_index

LlamaIndex is a data framework for your LLM applications

https://docs.llamaindex.ai

MIT License

36.74k stars 5.27k forks source link

Added docstrings and unit tests for `core.multimodal` #16872

Closed brycecf closed 6 days ago

brycecf commented 1 week ago

Description

multi_modal_llms/generic_utils.py didn't have docstrings or unit tests. These add those (and streamlines some logic.)
Added unit tests for multi_modal_llms.MultiModalLLMMetadata.
Moved infer_inmage_mimetype_from_* out of Anthropic MM-LLM to core.multi_modal.generic_utils to facilitate reusability across MM-LLM integrations. Added unit tests.

Type of Change

Unit tests with no breaking change.

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

[x] I added new unit tests to cover this change

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

brycecf commented 1 week ago

@logan-markewich It looks like there are unrelated tests failing from llama-index-integrations/readers/llama-index-readers-jira.