run-llama / llama_index

LlamaIndex is a data framework for your LLM applications
https://docs.llamaindex.ai
MIT License
36.74k stars 5.27k forks source link

Improvement/sambanova integration sambastudio #16930

Open rodrigo-92 opened 2 days ago

rodrigo-92 commented 2 days ago

Description

Integration of SambaStudio to the sambanova LLM integration module in LlamaIndex.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

Type of Change

Please delete options that are not relevant.

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

Suggested Checklist:

review-notebook-app[bot] commented 2 days ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

rodrigo-92 commented 2 days ago

hey @nerdai, hope you're doing fine. Here's the SambaStudio integration that I talked to you about days before. Please take a look and let me know if you have any questions or observations where I can help. Thanks in advance!

logan-markewich commented 2 days ago

@rodrigo-92 not sure if you missed this, but this is already published and released? https://docs.llamaindex.ai/en/latest/examples/llm/sambanova/

rodrigo-92 commented 2 days ago

@logan-markewich awesome! although in this PR we're updating the notebook including SambaStudio. Is that ok?

logan-markewich commented 2 days ago

@rodrigo-92 thats fine -- but lets edit the PR to keep the same class names/folder names etc?

Also, I noticed the notebook makes some mentions of the langchain-index-integrations package -- I think this is some leftover copy-pasta

rodrigo-92 commented 2 days ago

ok langchain mentions removed in notebook. What do you mean keeping the same class names/folder names?

logan-markewich commented 1 day ago

@rodrigo-92 I meant, you renamed all the folders to sambanova instead of sambanovacloud

rodrigo-92 commented 1 day ago

hey @logan-markewich please let me know if the changes work for you and if there's anything else.