Open justindhillon opened 8 months ago
Nice idea! Maybe it would be useful to add sth like " Run ruff check .
before pushing.
Nice idea! Maybe it would be useful to add sth like " Run
ruff check .
before pushing.
Sounds great! The CONTRIBUTING.md file now looks like this:
git checkout -b my-new-feature
)ruff check .
)git commit -am 'Add some feature'
)git push origin my-new-feature
)Great addition @justindhillon !
@justindhillon i think there's a lint error, could you run make format; make lint
?
@justindhillon i think there's a lint error, could you run
make format; make lint
?
Thanks @jerryjliu ! I ran the commands and now all tests pass. I also added the formating your code step to the Contributing.md file. It now looks like this:
git checkout -b my-new-feature
)ruff check .
)make format; make lint
)git commit -am 'Add some feature'
)git push origin my-new-feature
)Ready to merge.
CONTRIBUTING.md tells new contributors how to make pull requests. Here is what it looks like:
Contributing
git checkout -b my-new-feature
)git commit -am 'Add some feature'
)git push origin my-new-feature
)