run-youngjoo / SC-FEGAN

SC-FEGAN : Face Editing Generative Adversarial Network with User's Sketch and Color (ICCV2019)
Other
3.35k stars 530 forks source link

Undefined names: 'x' and 'DictAsMember' #4

Open cclauss opened 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/JoYoungjoo/SC-FEGAN on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./ops.py:12:20: F821 undefined name 'x'
        x = tf.pad(x, [[0,0], [p, p], [p, p], [0,0]], mode=padding)
                   ^
./utils/config.py:23:21: F821 undefined name 'DictAsMember'
            value = DictAsMember(value)
                    ^
2     F821 undefined name 'x'
2

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

run-youngjoo commented 5 years ago

Oh, thank you for letting us know a good lib for debugging. I will fix that!

cclauss commented 5 years ago

'x' was solved but 'DictAsMember' is still a problem.