search

runabol / piper

piper - a distributed workflow engine
Apache License 2.0
489 stars 87 forks source link

support MySQL #11

Closed muranoya closed 4 years ago

muranoya commented 6 years ago

I want to use MySQL.

Used DATETIME instead of TIMESTAMP because TIMESTAMP cannot be NOT NULL on MySQL. I tested lightly, there is no problem.

runabol commented 6 years ago

I like the intention but the problem is that despite the good faith of the SQL standard the various database vendors have wildly different implementations for things that are not covered in the standard. e.g.: full text search, JSON support etc.

So in order to support another database vendor we would need to either NOT take advantage of database-specific features (which can be costly/wasteful) or create database-specific implementations of JobRepository, TaskExecutionRepository etc.

Either way it's a bit of a can of worm.

muranoya commented 6 years ago

I understood the problem. Thanks. I try to this issue. Perhaps it may take time.

muranoya commented 6 years ago

I saw the source codes, but its are composed usual SQL statement (JSON and full text search, etc are not used in its). JSON is used as text, but it handles by Java code, not using SQL support. So, I feel that I don't need to special changing.