search

runabol / piper

piper - a distributed workflow engine
Apache License 2.0
487 stars 86 forks source link

Pipeline task #4

Closed vascofg closed 6 years ago

vascofg commented 6 years ago

Is it possible to call other pipelines by their "pipelineId" as Tasks from another pipeline, and pass them parameters?

runabol commented 6 years ago

Not yet. but definitely on the road map. I'll take a look tonight.

runabol commented 6 years ago

The primitives are there. Pipelines already have the notion of inputs and outputs at a pipeline level. So I imagine something like starting a sub-workflow and using its output as the output of that task. Also probably creating a new TaskDispatcher implementation is how I would want to implement it.

runabol commented 6 years ago

@vascofg far from complete but I started working on it: https://github.com/creactiviti/piper/tree/subflows

vascofg commented 6 years ago

looking great! On Thu, 2018-09-06 at 19:17 -0700, Arik Cohen wrote:

@vascofg far from complete but I started working on it: https://github.com/creactiviti/piper/tree/subflows

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c5 5493e4bb","name":"GitHub"},"entity":{"external_key":"github/creactivi ti/piper","title":"creactiviti/piper","subtitle":"GitHub repository","main_image_url":" https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":" https://github.com/creactiviti/piper"}},"updates":{"snippets":[{"icon":"PERSON","message":"@creactiviti in #4: @vascofg far from complete but I started working on it: https://github.com/creactiviti/piper/tree/subflows"}],"action":{"name":"View Issue","url":" https://github.com/creactiviti/piper/issues/4#issuecomment-419298868" }}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": " https://github.com/creactiviti/piper/issues/4#issuecomment-419298868" , "url": " https://github.com/creactiviti/piper/issues/4#issuecomment-419298868" , "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [creactiviti/piper] Pipeline task (#4)", "sections": [ { "text": "", "activityTitle": "Arik Cohen", "activityImage": " https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@creactiviti", "facts": [

] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"creactiviti/piper\",\n\"issueId\": 4,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"creactiviti/piper\",\n\"issueId\": 4\n}" }, { "targets": [ { "os": "default", "uri": " https://github.com/creactiviti/piper/issues/4#issuecomment-419298868" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 284642148\n}" } ], "themeColor": "26292E" } ]

runabol commented 6 years ago

I merged the changes. Feel free to try it out and provide feedback