runabol / piper

piper - a distributed workflow engine
Apache License 2.0
487 stars 86 forks source link

two sequential events for same task are send to two different queues #52

Open ravikishore1979 opened 3 years ago

ravikishore1979 commented 3 years ago

Hi Team,

Please can anyone clarify me regarding the below two points?

1) Two sequential events of a task "STARTED" and "COMPLETED" are going to two different queues "Queues.EVENTS" and "Queues.COMPLETIONS". Because of two queues for same task state, "Queues.COMPLETIONS" will be processed before "Queues.EVENTS". Though in "TaskStartedEventListener.java" we are updating the DB only if startTime is null. I feel this is a temporary fix. So my question is can we push "Completion" event also to "Queues.Events" queue?

2) During handling of the Event, I am setting few more properties to "TaskExecution" Object, So while creating PiperEvent, can we send TaskExecution Object also as part of PiperEvent?

Regards, Ravi Kishore. K