Job.status webhooks don't notify of STARTED status

runabol / piper

piper - a distributed workflow engine

Apache License 2.0

487 stars 86 forks source link

Job.status webhooks don't notify of STARTED status #8

Closed vascofg closed 6 years ago

vascofg commented 6 years ago

I've started using Webhooks (thanks a lot for the updated documentation btw) but have encountered the following issue: I get notified of CREATED and COMPLETED events, but not of STARTED ones. I believe there is a bug on this line, which publishes the event before changing the status. Is this it or am I understanding incorrectly? Also the notification of the CREATED status seems unnecessary, we already get it on the response to the create job request.

runabol commented 6 years ago

Yes, that totally looks like a silly bug.

On the CREATED though it might be useful if you want to notify a 3rd party application.

vascofg commented 6 years ago

d5be235a4d5eaab4739ba54ed46ccc4559bfdcf7 fixed it, thanks!