runapp-aus / strayr

A catalogue of ready-to-use ABS coding structures. Package documentation can be found here: https://runapp-aus.github.io/strayr/
45 stars 14 forks source link

reduce threshold for fuzzy matching in clean_state() #112

Closed MattCowgill closed 7 months ago

MattCowgill commented 7 months ago

closes https://github.com/runapp-aus/strayr/issues/111

clean_state() has an argument max_dist. A higher value permits 'fuzzier' matches, a lower value requires stricter matches.

This PR changes the default value of max_dist from 0.4 to 0.2. This will reduce spurious matches (as documented in the issue #111 ) at the potential cost of more failed 'true matches'. In my view this trade-off is worth it, and testing suggests this will not be a significant issue. Users remain able to manually specify max_dist if they do not want to accept the default value.