search

runapp-aus / strayr

A catalogue of ready-to-use ABS coding structures. Package documentation can be found here: https://runapp-aus.github.io/strayr/
45 stars 14 forks source link

Update get_seifa() to download different release year. #90

Closed JustGitting closed 1 year ago

JustGitting commented 1 year ago

Hi,

I thought to try adding the functionality I requested in issue #89.

I've updated get_seifa() with a new parameter year that can be a string or integer of the SEIFA release year. e.g. 2011, 2016. Plus some other minor edits.

I have not updated the unit-tests as I'm not sure what style/structure runapp-aus prefers. Happy to fix up if needed.

When ABS releases SEIFA for 2021, the modifications in this PR should allow for relatively painless updates.

mrjoh3 commented 1 year ago

Great idea and thanks for the PR, I will have a look at soon as I can.

If you look in the tests folder you will see an existing unit test for get_seifa. You should be able to update this to test for the new functionality.

Cheers

On Fri, 10 Mar 2023, 15:11 JustGitting, @.***> wrote:

Hi,

I thought to try adding the functionality I requested in issue #89 https://github.com/runapp-aus/strayr/issues/89.

I've updated get_seifa() with a new parameter year that can be a string or integer of the SEIFA release year. e.g. 2011, 2016. Plus some other minor edits.

I have not updated the unit-tests as I'm not sure what style/structure runapp-aus prefers. Happy to fix up if needed.

When ABS releases SEIFA for 2021, the modifications in this PR should allow for relatively painless updates.

You can view, comment on, or merge this pull request online at:

https://github.com/runapp-aus/strayr/pull/90 Commit Summary

File Changes

(5 files https://github.com/runapp-aus/strayr/pull/90/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/runapp-aus/strayr/pull/90, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOVGAKFPZ4PHJFQJKC2VQLW3KSXZANCNFSM6AAAAAAVV5WGAQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

JustGitting commented 1 year ago

Great, I'll add the unit tests by next week.