Closed JustGitting closed 1 year ago
Great idea and thanks for the PR, I will have a look at soon as I can.
If you look in the tests folder you will see an existing unit test for get_seifa. You should be able to update this to test for the new functionality.
Cheers
On Fri, 10 Mar 2023, 15:11 JustGitting, @.***> wrote:
Hi,
I thought to try adding the functionality I requested in issue #89 https://github.com/runapp-aus/strayr/issues/89.
I've updated get_seifa() with a new parameter year that can be a string or integer of the SEIFA release year. e.g. 2011, 2016. Plus some other minor edits.
I have not updated the unit-tests as I'm not sure what style/structure runapp-aus prefers. Happy to fix up if needed.
When ABS releases SEIFA for 2021, the modifications in this PR should allow for relatively painless updates.
You can view, comment on, or merge this pull request online at:
https://github.com/runapp-aus/strayr/pull/90 Commit Summary
- 32d632d https://github.com/runapp-aus/strayr/pull/90/commits/32d632d5aad955cfd98a08f575529119557ed9b0 Added year parameter, updated docs, modified get_seifa() and get_seifa_index_sheet() functions to also retrieve 2011 SEIFA release.
- 6e60a94 https://github.com/runapp-aus/strayr/pull/90/commits/6e60a9453e0a2136d2a31fcc8fbba4b07f8bed8b Namespace file was modified by build system to include lubridate functions.
- d72fc9c https://github.com/runapp-aus/strayr/pull/90/commits/d72fc9ca59682eb3daa92e5e611f9b4c7cd05a30 map_dfr() is depreciated, replaced with map() / list_rbind().
- 684494a https://github.com/runapp-aus/strayr/pull/90/commits/684494a1cdea5396e7498984f773d291e8142b6e Namespace and Rd files updated during build.
File Changes
(5 files https://github.com/runapp-aus/strayr/pull/90/files)
- M NAMESPACE https://github.com/runapp-aus/strayr/pull/90/files#diff-b6b6854a02ae177f8860f49654ff250c1554d021ae434b6efdbe99d00bdc6055 (5)
- M R/seifa.R https://github.com/runapp-aus/strayr/pull/90/files#diff-5be0ecc7bb84ca8ee997ad62f0055cc4cf072535949d2b21a124b13d619279ea (64)
- M man/aus_seasons.Rd https://github.com/runapp-aus/strayr/pull/90/files#diff-cc9d5700c3f159856257b2c102ff356f73443b346b9f772d8ecde0c6cd808c90 (4)
- M man/get_seifa.Rd https://github.com/runapp-aus/strayr/pull/90/files#diff-f0b40b7381f7e4e69e997abbd90ee16d610f7d1a5041556be0593c5233898d5d (7)
- M man/get_seifa_index_sheet.Rd https://github.com/runapp-aus/strayr/pull/90/files#diff-997582412350e7ef3d0a11f79c7c4424b185eaf54d75256ffdce4e3f4cdb2c92 (3)
Patch Links:
- https://github.com/runapp-aus/strayr/pull/90.patch
- https://github.com/runapp-aus/strayr/pull/90.diff
— Reply to this email directly, view it on GitHub https://github.com/runapp-aus/strayr/pull/90, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOVGAKFPZ4PHJFQJKC2VQLW3KSXZANCNFSM6AAAAAAVV5WGAQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Great, I'll add the unit tests by next week.
Hi,
I thought to try adding the functionality I requested in issue #89.
I've updated get_seifa() with a new parameter
year
that can be a string or integer of the SEIFA release year. e.g. 2011, 2016. Plus some other minor edits.I have not updated the unit-tests as I'm not sure what style/structure runapp-aus prefers. Happy to fix up if needed.
When ABS releases SEIFA for 2021, the modifications in this PR should allow for relatively painless updates.