search

runapp-aus / strayr

A catalogue of ready-to-use ABS coding structures. Package documentation can be found here: https://runapp-aus.github.io/strayr/
45 stars 14 forks source link

Strayr imports `purrr::list_rbind()` which is only in new versions of purrr #96

Closed MattCowgill closed 10 months ago

MattCowgill commented 1 year ago

A recent PR (@baslat's?) imports purrr::list_rbind(). This function is only precent in recent versions of purrr -- I think 1.0+. I just got an error trying to use an older version of purrr and strayr together.

Two options: 1) Be explicit in strayr's DESCRIPTION that it requires purrr >= 1.0.0 2) Remove the list_rbind() dependency

I favour option 1 but wanted to post an issue to see if there's any disagreement

baslat commented 1 year ago

It can use map_dfr instead of map and list_rbind if that is more backwards compatible.

MattCowgill commented 1 year ago

The downside then is that map_dfr is deprecated (or at least superseded).... I'm inclined to leave the code as it is and just require >= 1.0.0

baslat commented 1 year ago

I think that is the correct approach. Only downside I can see is if people are on restrictive environments (yet somehow access GitHub) and cannot update purrr.

MattCowgill commented 10 months ago

Resolved https://github.com/runapp-aus/strayr/pull/106