Open dmattia opened 4 years ago
So this is as a result of our logic for splitting comments being naive and assuming that we're splitting in the middle of a plan/apply output. In your case we ended up splitting in the middle of the commands output and so when we apply
```diff
it borks all the markdown.
I think the true fix here is for the markdown renderer to return a struct that describes the output better rather than just a string. Then the splitting functionality can be smarter about where it splits long comments.
It seems we are facing the current issue as well. I really like the elegant solution that @lkysow is suggesting here and i think this will straight solve the https://github.com/runatlantis/atlantis/issues/1021 as well. What do you think? I can also spend some time on this matter to make those problems go away 😄
is this still an issue with v0.19.8
?
It appears to be
We are noticing some cases where our plans appear to skip over many plans because of invalid markdown.
As an example, we recently ran atlantis over a PR that affected ~150 modules. Here is the end of one comment:
Warning: Output length greater than max comment size. Continued in next comment.
This causes the plan to appear to jump forward and skip quite a number of outputs:
If I go to "edit" the comment in between the jump, I can see all of the missing job outputs