Apply error: "Saved plan does not match the given state"

alfredo-gil commented 2 years ago

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

I'm trying to update atlantis to the latest version v0.19.3 but I'm getting the same error starting with the version v0.18.2. When I try to do atlantis apply the apply failed and I get this error:

 Error: Saved plan does not match the given state

 The given plan file can not be applied because it was created from a
 different state lineage.

So when the same workflow it works on version v0.18.1 but starts failing on v0.18.2 and the problem persist on the latest version v0.19.3

Reproduction Steps

Currently, I'm using a simple terraform code to create an s3 bucket.

terraform version: 1.1.9 providers:

aws version = "~> 3.74"

This is the terraform provider block:

terraform {
  required_providers {
    aws = {
      source = "hashicorp/aws"
      version = "~> 3.74"
    }
  }

  required_version = "1.1.9"
}

Environment details

We pass specific values through environment variables Atlantis server-side config file:

# config file
- name: ATLANTIS_HIDE_PREV_PLAN_COMMENTS
   value: 'true'
- name: ATLANTIS_ENABLE_DIFF_MARKDOWN_FORMAT
   value: 'true'
- name: ATLANTIS_LOG_LEVEL
   value: debug
- name: ATLANTIS_DATA_DIR
   value: /atlantis-data
- name: ATLANTIS_PORT
   value: '4141'

Repo atlantis.yaml file:

# config file
---
version: 3
automerge: true
projects:
- name: devbroker
  dir: ./
  workspace: devbroker
  autoplan:
    when_modified: ["**/*.tf", "*.tfvars", "configuration/**/*.yaml"]
    enabled: true

Our custom workflow is this:

        plan:
          steps:
          - env:
              name: TF_WORKSPACE
              command: echo "${WORKSPACE}"
          - init:
              extra_args: ["-backend-config", "./backends/${WORKSPACE}.conf"]
          - run: terraform${ATLANTIS_TERRAFORM_VERSION} workspace new "${WORKSPACE}" || true
          - plan
        apply:
          steps:
          - env:
              name: GITHUB_BASE_URL # for GitHub Enterprise
              command: echo "https://${ATLANTIS_GH_HOSTNAME}/api/v3/"
          - env:
              name: GITHUB_TOKEN
              command: echo "${ATLANTIS_GH_TOKEN}"
          - env:
              name: CONFIG_PATH
              value: /etc/atlantis/atlantis-org-applyer.yaml
          - apply

Additional Context

We saw that between version v0.18.1 and version v0.18.2 the post workflows had been introduced.

jccarte commented 2 years ago

I ran into this same issue. It seemed to work once I added TF_WORKSPACE to my apply step. I think this change caused the issue: https://github.com/runatlantis/atlantis/pull/2006

- env:
     name: TF_WORKSPACE
     command: echo "${WORKSPACE}"

alfredo-gil commented 2 years ago

Many many thanks @jccarte !!! It works like a charm!!

alfredo-gil commented 2 years ago

Many many thanks @jccarte !!! It works like a charm!!

runatlantis / atlantis