jamengual
commented
2 years ago this only happens in bitbucket? I think I have seen this on github long ago, and just last week I was testing the max post size and it seemed that github can do far more that it is coded which could reduce the additional comments, but it will need testing.
On Sun, Oct 2, 2022, 9:36 a.m. wpbeckwith @.***> wrote:
Community Note
- Please vote on this issue by adding a 👍 reaction https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
- If you are interested in working on this issue or have submitted a pull request, please leave a comment.
- I'd be willing to implement this feature (contributing guide https://github.com/runatlantis/atlantis/blob/master/CONTRIBUTING.md)
Describe the user story
When Atlantis posts the terraform output back to a PR, if the output exceeds the single comment limit, then atlantis will post several comments. However the order of these comments is sub-optimal. Assuming atlantis needs to post 3 comments for the full output then the PR will read like
5 # start of 3rd comment
...
6 # end of 3rd comment
3 # start of 2nd comment
...
4 # end of 2nd comment
1 # start of 1st comment
...
2 # end of 1st comment
The current ordering requires a user to scan to section 1 and read to section 2, then scroll back up past sections 1 and 4 to find section 3 and read to 4, then repeat again and scroll to section 5 and finally finish at 6.
Describe the solution you'd like
Atlantis should reverse the order of the array before it posts the comments, then the PR will read like
1 # start of 1st comment
...
2 # end of 1st comment
3 # start of 2nd comment
...
4 # end of 2nd comment
5 # start of 3rd comment
...
6 # end of 3rd comment
This now reads more naturally from top to bottom. Even if another PR comment somehow was included while Atlantis was posting its comments, it would still retain the easier top down reading.
Describe the drawbacks of your solution
This section is important not only to identify future issues, but also for us to see whether you thought through your request. When filling it, ask yourself what are the problems we could have maintaining what you propose. How often will it break?
None known as this should be an option to reverse the posting behavior.
Describe alternatives you've considered
We have implemented the change here, 66a21de https://github.com/runatlantis/atlantis/commit/66a21de4946208f167df5f926f7949a43947eb3d, minus a server config option to control the reversal.
— Reply to this email directly, view it on GitHub https://github.com/runatlantis/atlantis/issues/2547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ3ERH2AFSFHEYDSIYXWQLWBG22VANCNFSM6AAAAAAQ27BNOE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
wpbeckwith
nitrocode
Community Note
Describe the user story
When Atlantis posts the terraform output back to a PR, if the output exceeds the single comment limit, then atlantis will post several comments. However the order of these comments is sub-optimal. Assuming atlantis needs to post 3 comments for the full output then the PR will read like
The current ordering requires a user to scan to section 1 and read to section 2, then scroll back up past sections 1 and 4 to find section 3 and read to 4, then repeat again and scroll to section 5 and finally finish at 6.
Describe the solution you'd like
Atlantis should reverse the order of the array before it posts the comments, then the PR will read like
This now reads more naturally from top to bottom. Even if another PR comment somehow was included while Atlantis was posting its comments, it would still retain the easier top down reading.
Describe the drawbacks of your solution
This section is important not only to identify future issues, but also for us to see whether you thought through your request. When filling it, ask yourself what are the problems we could have maintaining what you propose. How often will it break?
None known as this should be an option to reverse the posting behavior.
Describe alternatives you've considered
We have implemented the change here, https://github.com/runatlantis/atlantis/commit/66a21de4946208f167df5f926f7949a43947eb3d, minus a server config option to control the reversal.