Rerunning a plan or running an apply should set `atlantis/post_workflow_hook` to `pending`

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

Rerunning a plan or running an apply should set atlantis/post_workflow_hook to pending

This issue may also affect atlantis/pre_workflow_run

Reproduction Steps

Open a PR
Run atlantis plan
Rerun atlantis plan
Notice that the atlantis/post_workflow_hook is stuck in "succeeded" instead of going to "pending"

Logs

N/A

Environment details

Atlantis version: 0.22.3

Atlantis server-side config file:

repos:
  - id: /.*/
    apply_requirements:
      - mergeable
      - approved
    workflow: terraform
    post_workflow_hooks:
      - run: |
          echo "Post workflow run completed successfully"

Additional Context

See related PR https://github.com/runatlantis/atlantis/pull/2441
cc: @Fabianoshz

The only way to know it is a different run is due to the job id changing in the URL.

Hi @nitrocode, I tried to reproduce this and I got this behaviour:

Rerun plan;
Post/pre workflow hooks initially stays at succeeded since it was the last update;
When reaching the pre workflow phase each workflow changes to pending, then to succeeded again;
Same for post workflow.

If your pre/post workflow hooks are being executed really fast (like when using an echo) you're not going to see the status being updated to pending because github (or other VCS client) will receive 2 updates in a very short time. You can test using a sleep command.

What we can do is to change the current implementation to reset every pre/post workflow even before running the received command, this would set every workflow to pending even before running the first command.

runatlantis / atlantis