Lack of GH App permission fails pre-hook but runs plan/apply as usual

kirek007 commented 11 months ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

In case Github App is missing permission to update commit status, atlantis is not running pre-hook but it's running workflows as usual. This behavior is not consistent across pre and post hook but also plan/apply phases.

Reproduction Steps

Create an GH App without commit status r/w permissions

Logs

Environment details

Additional Context

X-Guardian commented 11 months ago

@GenPage, I think you have accidentally linked to and closed this issue from the vuepress fix PR 3611.

GenPage commented 11 months ago

whoops 🙃

runatlantis / atlantis