Open maxblaze opened 5 years ago
It would require a code change and would break backwards compatibility. What other service is using the "run" keyword (for my knowledge). Is it possible to change that service?
To be clear, I'm not 100% against this because all the docs tell people to use atlantis
.
So one thing that might work--is it possible to configure a global run
command that does nothing using the existing configs?
We can change our command, it just caught us off-guard because it wasn't clearly documented =)
run
maps directly to atlantis
.I want to reach out to some users to see if they're using that command. That might take a while so I don't think this will be implemented super soon.
In that time you could either fork the repo, delete the run
word from this line: https://github.com/runatlantis/atlantis/blob/master/server/events/comment_parser.go#L124 and compile and run it or you could maybe change your command.
@lkysow would you be open to a PR that adds an option to disable this keyword for those of us who already have other systems trigger on it? It can stay on by default to remain backwards compatible.
We could add a flag --trigger-word
?
I was just creating a PR implementing --disable-run-trigger-keyword
, but if you think a more general configuration setting is suitable, I'd be happy to change it to that with a default value of []string{"atlantis", "run"}
. We could then append the VCS user inside CommentParser.Parse(...)
(we'd add trigger keywords as a struct field on CommentParser
), so the functionality would remain the same.
Sounds good!
Is there a way to turn off the interception of the custom
run
commands? We're already usingrun foo
for another service integrated with GitHub and Atlantis is spamming a message that the command isn't found.