runatlantis / atlantis

Terraform Pull Request Automation
https://www.runatlantis.io
Other
7.54k stars 1.02k forks source link

Support github codeowners with branch protection on codeowners #4450

Open nitrocode opened 3 months ago

nitrocode commented 3 months ago

Community Note


Overview of the Issue

Approval by non-codeowner allows the apply and fails to merge

Reproduction Steps

The github repo has codeowners The branch protections enforce codeowners The pr was approved by a NON codeowner atlantis apply was commented terraform apply was run (which shouldn't have happened) pr failed to merge atlantis/apply pr check is in a failed state

Logs

n/a

Environment details

0.27.2

Additional Context

n/a

stasostrovskyi commented 2 months ago

Atlantis cannot reflect every single permutation of what people consider a PR to be ok to be applied/merged, but GitHub can. So I guess right way forward is to use mergeable as apply_requirement and configure everything else in branch protection/rulesets.