search

runatlantis / atlantis

Terraform Pull Request Automation
https://www.runatlantis.io
Other
7.73k stars 1.05k forks source link

fix: Add support for the X-Hub-Signature-256 header #4629

Closed gerardsegarra closed 3 months ago

gerardsegarra commented 4 months ago

what

Add support for the X-Hub-Signature-256 header

why

Set the SHA256 header as the default and falling back to the SHA1 header when the SHA256 header is empty. The GitHub documentation recommends using the SHA256 header so I don't expect the fallback to be needed in a live environment. Still, this fallback prevents introducing breaking changes when used in tests.

tests

references

This solution is based on this PR from @reinoudk

gerardsegarra commented 4 months ago

@chenrui333 are you planning on merging this? 😸

gerardsegarra commented 3 months ago

Okay, I miss understood the code. I'll close the PR 😓