Atlantis merges the PR even when the "atlantis apply" fails.

[snehalsn]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

We have noticed that there are instances where atlantis goes ahead with merging a PR in the event of an apply error which seems to be a bug in the system. Ideally, when the atlantis apply results in an error, it should not merge the PR.

Screenshot :

Reproduction Steps

1. Raised the PR
2. Ran atlantis plan which showed the expected changes.
3. Ran atlantis apply . This resulted in the Apply Failed error stating "Pull request must be mergeable before running apply." It should have stopped at this stage on failure, however, atlantis went ahead and merged the PR.

Environment details

• Atlantis version: v0.26.0
• Atlantis flags:

Atlantis server-side config file: We use upstream server-side config

Repo atlantis.yaml file:

 - name: <project_name>
    dir: <directory_path>
    workspace: <workspace_name>
    terraform_version: "1.3.9"
    autoplan:
      when_modified: ["*.tf", "**/*.tf"]
      enabled: true

[jamengual]

are the status required for merging? if not then it will not care.

[snehalsn]

yes... if the apply fails, then the PR should not be merged.

[jamengual]

Which VCS do you use?

[snehalsn]

Github