search

runatlantis / atlantis

Terraform Pull Request Automation
https://www.runatlantis.io
Other
7.73k stars 1.05k forks source link

fix: add app to the github app installation id #4650

Closed bdellegrazie closed 3 months ago

bdellegrazie commented 3 months ago

what

A tiny fix to correct the terminology used for the Github App Installation ID so it includes "App" as does the rest of the Github App configuration items.

This is a trivial PR to build on @john-tipper 's fine work - it's not intended to devalue the serious effort made to address the original requirement (thank you!)

why

purely for naming consistency and ease of use.

tests

Existing tests updated to use the new name. Documentation updated too.

references

fixes #4579

bdellegrazie commented 3 months ago

@jamengual this is the additional PR discussed in #4579

bdellegrazie commented 3 months ago

@chenrui333 / @jamengual there's a test failure related to a lock file restriction but I haven't changed anything in this area - it's a required CI pass though so can anyone help here?

chenrui333 commented 3 months ago

agree, I need to fix the issue first.

chenrui333 commented 3 months ago

I have fixed the tests per https://github.com/runatlantis/atlantis/pull/4653 refreshed the pr and rerun

chenrui333 commented 3 months ago

@bdellegrazie Thanks for your first contribution to atlantis!! 🎉