search

runatlantis / atlantis

Terraform Pull Request Automation
https://www.runatlantis.io
Other
7.51k stars 1.02k forks source link

Allow for plans to be partially successful #4709

Open shkamensky opened 5 days ago

shkamensky commented 5 days ago

When automerge is true, if any plan fails, all plans get deleted

This is true even when running from a github comment. When dealing with many projects, there is a high likelihood that one plan can fail.

This allows us to keep apply some plans and reiterate so we don't lose all progress.

what

Allow for plans to be saved when automerge is true by passing a flag.

why

Because the all-or-nothing nature of saving plans can make it very difficult to apply across many projects. For example, if 1 failed because of a DNS issue and 150 others plans succeeded, we want to apply the plans that succeeded and deal with the 1 plan manually.

tests

references

https://github.com/runatlantis/atlantis/issues/3002

jamengual commented 5 days ago

hi @shkamensky this will require some reviews that will take some time , in the meantime please add docs and tests. Thanks