search

runatlantis / atlantis

Terraform Pull Request Automation
https://www.runatlantis.io
Other
7.83k stars 1.06k forks source link

fix: Resolve Rendering Issue in the Policy Check Results Template #4870

Closed dorian-tsorfy closed 2 months ago

dorian-tsorfy commented 2 months ago

what

I added a space line to the policy_check_results_wrapped.tmpl file so the output on GitLab will look nice. Resolving issue #4623.

why

We have noticed intermittent issues rendering the markdown Atlantis outputs to GitLab when a policy check failure occurs ever since upgrading from v0.27.3 to v0.28.1. I suspect this could be related to https://github.com/runatlantis/atlantis/pull/4254 and the formatting changes it made.

tests

references

4623

4787

dorian-tsorfy commented 2 months ago

@X-Guardian, Uploaded here a new PR for the space line

dorian-tsorfy commented 2 months ago

@jamengual Hi I created the PR again of adding a space line

X-Guardian commented 2 months ago

Thanks @dorian-tsorfy, can you check this comment to see whether further fixes are needed: https://github.com/runatlantis/atlantis/issues/4623#issuecomment-2277870985

dorian-tsorfy commented 2 months ago

Thanks @dorian-tsorfy, can you check this comment to see whether further fixes are needed: #4623 (comment)

Done

dorian-tsorfy commented 2 months ago

@GenPage @jamengual Hey guys, I saw my PR is included in the latest release v0.29.0 although it was reverted (check #4787). I then created this PR that passes all the tests and is waiting to be merged.