search

runatlantis / helm-charts

Atlantis Helm Chart
Apache License 2.0
114 stars 183 forks source link

Is it possible to deprecate this repo in favor of stakater/application #286

Closed nitrocode closed 5 months ago

nitrocode commented 1 year ago

ref: https://github.com/stakater/application

nitrocode commented 1 year ago

Hi @jseiser , could you please add some comments here.

The reason I proposed this is that it's hard to keep this project up to date and it would be nice to find easier solutions than to continue to maintain a chart ourselves.

jseiser commented 1 year ago

@nitrocode

It really should not be too much trouble to keep it up to date. As soon as you give up control of this chart, you will still have to answer questions from people about it, but it will be less flexible and out of your control.

The biggest problem I see ( and also the one i have the least experience with ) is that we need more/better Github Actions.

  1. Stable releases should automatically get updated appVersions, and bumping the chart versions
  2. Merges should have a workflow that builds/deploys the chart into KinD so we can verify that it does indeed deploy.
  3. All MR's should probably be templates, and ran against kubeval or kubeconform or something
  4. Im a big fan of forcing semantic versioning by git commits. so forcing all PR's to come in, squashed with 1 commit that has a proper message that software can in turn use to generate a new release. ( https://github.com/marketplace/actions/action-for-semantic-release )

Biggest problem for me, is we do all this with our own charts, but ive been on gitlab for so long Github Actions are rather foreign.

nitrocode commented 1 year ago

Thank you for the explanation. I agree that all of these would solve some of the issues in this chart, however, this chart would still need to be maintained, have features added to it, etc. For example, some features that we've added (and also arguably reinvented) are already managed by stakater/application.

We could start copy and pasting only the parts we need from stakater but then at what point do we say, why not just use the upstream chatt and have an example values.yaml file to feed it to get the expected template.

Otherwise since the maintainers in this org have limited cycles, sometimes PRs and helm chart issues (like the ones that plague this repo) end up languishing in the backlog.

We're also looking for volunteers so if you have ideas or want to discuss future maintainance and how to help, please join the slack community and #contributors slack channel. Also please feel free to put in PRs. You can fork this repo and play with the github actions, release your own chart, etc and see if it does what it expects. 😄

jseiser commented 1 year ago

Im in slack, have 2 open PR's, and 3 merged ones. Im trying :D

The best thing to take from that repo, may be their github actions.

jamengual commented 1 year ago

there is a ton of people using this repo so deprecating is just not going to be an option.

We always need more contributors/maintainers so maybe @jseiser you want to be part of that group for the helm-chart repo?

GMartinez-Sisti commented 5 months ago

I agree that we should keep our own chart to be able to adapt and customize to the requirements of atlantis.

Can we close this? @nitrocode @jamengual ?