runatlantis / helm-charts

Atlantis Helm Chart
Apache License 2.0
114 stars 182 forks source link

aws cli cache directory unwritable #380

Open ryan-dyer-sp opened 5 months ago

ryan-dyer-sp commented 5 months ago

The default aws cli cache directory (/home/atlantis/.aws/cli) is unwritable as the aws secret is mounted as as the entire /home/atlantis/.aws directory.

When dealing with lots of profiles, etc. it is nice to have the aws cli tool available in atlantis (we build our own image w/ additional toolsets installed). But the helm chart's existing method for managing the aws secret doesnt allow the aws cli to work out of the box.

I will submit a PR shortly to iterate through the aws objects and mount them individually as files within the .aws directory instead.

GMartinez-Sisti commented 5 months ago

Hi @ryan-dyer-sp, as replied on our Community Slack:

Hi Ryan, thanks in advance for the contribution :smile: . I’d say it’s best to send the PR and then we can review it. One important detail is to ensure there are no breaking changes, otherwise it needs to be explained with migration steps.

GMartinez-Sisti commented 4 months ago

Would a similar approach work for this? https://github.com/runatlantis/helm-charts/pull/384